Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): force CustomSelect's to rerender when models load to update invalid state #5949

Merged
merged 3 commits into from
Mar 13, 2024
Merged

fix(ui): force CustomSelect's to rerender when models load to update invalid state #5949

merged 3 commits into from
Mar 13, 2024

Conversation

maryhipp
Copy link
Collaborator

@maryhipp maryhipp commented Mar 13, 2024 •
edited
Loading

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because:

Have you updated all relevant documentation?

  • Yes
  • No

Description

  • In some environments, the initial invalid state of an empty CustomSelect seems to get memoized and not updated when the items/selectedItem load. There is probably a better fix to be done in the CustomSelect component itself but this worked for now.

@github-actions github-actions bot added the frontend PRs that change frontend files label Mar 13, 2024
psychedelicious
psychedelicious approved these changes Mar 13, 2024
View reviewed changes
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gross, ty

@psychedelicious psychedelicious merged commit 1d2743a into main Mar 13, 2024
14 checks passed
@psychedelicious psychedelicious deleted the maryhipp/select-key branch March 13, 2024 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maryhipp @psychedelicious