fix(ui): control adapter errors #5953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There wasn't enough validation of control adapters during graph building. It would be possible for a graph to be built with empty collect node, causing an error. Addressed with an extra check. This should never happen in practice, because the invoke button should be disabled if an invalid CA is active.
The graph builders used awaited functions within `Array.prototype.forEach` loops. This doesn't do what you'd think. This caused graphs to be enqueued before they were fully constructed. Changed to `for..of` loops to fix this.
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
6 tasks
Until recently, this had a different shape than the ModelMetadataField. They are now the same, so we can re-use the ModelIdentifierField.
We can also totally remove the fetch logic because we store the same model data in state now.
github-actions
bot
added
python
|
I realized we can simplify things a bit more and followed this PR up with #5954. Since the changes are related, I just merged that PR into this one. Notes from that PR:
|
blessedcoolant
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Have you discussed this change with the InvokeAI team?
Description
Fix two failure modes for control adapter graph creation:
awaitwithin aforEachloop, causing a race conditionRelated Tickets & Documents
I saw a post on discord but cannot find it now.
QA Instructions, Screenshots, Recordings
Control adapters should work
Merge Plan
This PR can be merged when approved