fix(nodes,ui): metadata recall #5957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername and
brandonrising
as code owners
github-actions
bot
added
python
psychedelicious
force-pushed
the
psyche/fix/ui/metadata-recall
branch
from
7150cc4
to
9ff4cdb
Compare
brandonrising
approved these changes
Mar 14, 2024
maryhipp
approved these changes
Mar 14, 2024
In the client, a controlnet or t2i adapter has two images: - The source control image: the image the user selected (required) - The processed control image: the user's image after we've processed it (optional) The processed image is optional because a user may provide a pre-processed image. We only actually use one of these images when building the graph, and until this change, we only stored one of the in image metadata. This created a situation where only a processed image was stored in metadata - say, a canny edge map - and the user-selected image wasn't provided. By adding the processed image to metadata, we can recall both the control image and optional processed image. This commit is followed by a UI-facing changes to support the change.
- Add helper functions to build metadata for control adapters, including the processed images - Update parses to parse the new metadata
brandonrising
force-pushed
the
psyche/fix/ui/metadata-recall
branch
from
9ff4cdb
to
f11e173
Compare
hipsterusername
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Description
Related Tickets & Documents
QA Instructions, Screenshots, Recordings
Control Adapter and LoRA metadata recall should work.
Merge Plan
This PR can be merged when approved.