Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui, worker): update processed image resolution based on base model type #5986

Merged
merged 8 commits into from
Mar 19, 2024

Conversation

maryhipp
Copy link
Collaborator

@maryhipp maryhipp commented Mar 18, 2024

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update
  • Community Node Submission

Have you discussed this change with the InvokeAI team?

  • Yes
  • No, because:

Have you updated all relevant documentation?

  • Yes
  • No

Description

  • Updates the UI to dynamically calculate the default for control adapter processor depending on current base model - SDXL should produce processed images that are 1024x1024 by default, SD1/2 should produce processed images that are 512x512 by default
  • Adds image_resolution as an input option to some processors that didn't have it: canny, midas, mediapipe face, segment anything
  • Added UI for image resolution for processors that needed it: canny, midas, mediapipe face

Testing

  • test different processors with SDXL base model and SD1 base model - processed images should be 1024x1024 when SDXL is base model and 512x512 when SD1 is base model
  • test using canny, midas depth, and mediapipe face - image_resolution should now be a parameter that can be changed in the UI and impacts the resolution of processed image.

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations frontend PRs that change frontend files labels Mar 18, 2024
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@psychedelicious psychedelicious force-pushed the maryhipp/processor-resolution-base-model branch from caf55a5 to f1961ff Compare March 19, 2024 10:47
@psychedelicious psychedelicious enabled auto-merge (rebase) March 19, 2024 10:47
@psychedelicious psychedelicious merged commit 300a469 into main Mar 19, 2024
14 checks passed
@psychedelicious psychedelicious deleted the maryhipp/processor-resolution-base-model branch March 19, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files invocations PRs that change invocations python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants