fix(mm): handle integer state dict keys in probe #6051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
lstein,
blessedcoolant,
GreggHelt2,
brandonrising,
RyanJDick and
hipsterusername
as code owners
github-actions
bot
added
python
I don't have yet a developer install. after a quick glance over the related section of the docs, if it is useful for me to do so, I think I can try to look into it tomorrow if I don't run into unexpected issues setting that up. Don't hesitate to move forward with this if I take too long or my approval isn't necessary, there are too many things I am trying to do at the same time... |
hipsterusername
approved these changes
Mar 26, 2024
hipsterusername
force-pushed
the
psyche/fix/mm/cast_state_dict_keys_to_str
branch
from
a6881ec
to
7cb0b35
Compare
It's possible for a model's state dict to have integer keys, though we do not actually support such models. As part of probing, we call `key.startswith(...)` on the state dict keys. This raises an `AttributeError` for integer keys. This logic is in `invokeai/backend/model_manager/probe.py:get_model_type_from_checkpoint` To fix this, we can cast the keys to strings first. The models w/ integer keys will still fail to be probed, but we'll get a `InvalidModelConfigException` instead of `AttributeError`. Closes #6044
psychedelicious
force-pushed
the
psyche/fix/mm/cast_state_dict_keys_to_str
branch
from
7cb0b35
to
9dd28fc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
It's possible for a model's state dict to have integer keys, though we do not actually support such models.
As part of probing, we call
key.startswith(...)on the state dict keys. This raises anAttributeErrorfor integer keys.This logic is in
invokeai/backend/model_manager/probe.py:get_model_type_from_checkpointTo fix this, we can cast the keys to strings first. The models w/ integer keys will still fail to be probed, but we'll get a
InvalidModelConfigExceptioninstead ofAttributeError.Related Issues / Discussions
Closes #6044
QA Instructions
I'd like to get approval from @ljleb that this fixes the problem, but no worries if that's a bit too much work. I'm fairly confident that this change plus #6048 will resolve #6044 satisfactorily.
Merge Plan
N/A
Checklist