feat(installer): remove updater & support installing from wheel #6054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating should always be done via the installer. We initially planned to only deprecate the updater, but given the scale of changes for v4, there's no point in waiting to remove it entirely.
This allows us to easily test the installer without needing the desired version to be published on PyPI: ```sh python3 installer/lib/main.py --wheel installer/dist/InvokeAI-4.0.0rc6-py3-none-any.whl ``` A warning message and confirmation are displayed when the arg is used. The rest of the installer is unchanged.
This wasn't used at all.
Forgot to update this when removing references to updating the app in invoke.sh.in
psychedelicious
requested review from
lstein,
ebr,
hipsterusername and
blessedcoolant
as code owners
github-actions
bot
added
python
hipsterusername
approved these changes
Mar 26, 2024
psychedelicious
deleted the
psyche/feat/installer/remove-update-support-wheel
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Please see the commit messages for details.
Related Issues / Discussions
By removing the ability to update, we should reduce the number of user issues caused by user blindly updating to an RC without understanding how this could impact their data.
QA Instructions
You can test the wheel install by running
make installer-zipand then manually running the installer, pointing to the wheelpython3 installer/lib/main.py --wheel installer/dist/InvokeAI-4.0.0rc5-py3-none-any.whlMerge Plan
N/A
Checklist