feat(mm): remove hf token handling #6061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp,
hipsterusername,
lstein,
ebr and
brandonrising
as code owners
github-actions
bot
added
api
python
blessedcoolant
approved these changes
Mar 27, 2024
hipsterusername
approved these changes
Mar 27, 2024
I had added this because I mistakenly believed the HF token was required to download HF models. Turns out this is not the case, and the vast majority of HF models do not need the API token to download.
These two docs had overlap and were kinda the same thing.
psychedelicious
force-pushed
the
psyche/feat/mm/remove-hf-token-handling
branch
from
afce44c
to
90e2e72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I had added this because I mistakenly believed the HF token was required to download HF models.
Turns out this is not the case, and the vast majority of HF models do not need the API token to download.
Supporting changes:
docs: merge INSTALL_TROUBLESHOOTING into FAQ
As I was updating the docs for the HF token I merged these docs, centralizing all FAQ/troubleshooting stuff.
Related Issues / Discussions
N/A
QA Instructions
N/A
Merge Plan
N/A
Checklist