feat(installer): remove extra GPU options #6119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
lstein,
ebr,
hipsterusername and
blessedcoolant
as code owners
github-actions
bot
added
installer
hipsterusername
approved these changes
Apr 3, 2024
- Remove `CUDA_AND_DML`. This was for onnx, which we have since removed. - Remove `AUTODETECT`. This option causes problems for windows users, as it falls back on default pypi index resulting in a non-CUDA torch being installed. - Add more explicit settings for extra index URL, based on the torch website - Fix bug where `xformers` wasn't installed on linux and/or windows when autodetect was selected
Remove reference to the autodetect GPU device option.
psychedelicious
force-pushed
the
psyche/fix/installer/remove-extra-gpu-opts
branch
from
d9783ed
to
f9273c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
CUDA_AND_DML. This was for onnx, which we have since removed.AUTODETECT. This option causes problems for windows users, as it falls back on default pypi index resulting in a non-CUDA torch being installed.xformerswasn't installed on linux and/or windows when autodetect was selectedRelated Issues / Discussions
Discord thread where the user ended up with an incompatible version of
torchaudio(? why this was installed, I do not know) after choosing the autodetect option:https://discord.com/channels/1020123559063990373/1020123559831539744/1224998262100983829
Also another user at the same time had a problem with autodetect.
QA Instructions
Run the
install.sh.inscript to test the installer.I tested macOS and Linux (CUDA).
Merge Plan
n/a
Checklist