fix: "Use All" for linear image to image doesn't recall source image #6141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chainchompa
requested review from
psychedelicious,
blessedcoolant,
maryhipp and
hipsterusername
as code owners
invokeai/frontend/web/src/features/parameters/types/parameterSchemas.ts
Outdated
Show resolved
Hide resolved
psychedelicious
requested changes
Apr 5, 2024
psychedelicious
approved these changes
Apr 6, 2024
Retrieving the DTO happens as part of the metadata parsing, not recall. This way, we don't show the option to recall a nonexistent image. This matches the flow for other metadata entities like models - we don't show the model recall button if the model isn't available.
psychedelicious
force-pushed
the
recall-i2i-image
branch
from
f72bd5e
to
eecb088
Compare
|
I made a small change to improve the UX. I moved the image network request to the parsing logic. The parsing logic is intended to handle "does this metadata exist and is it valid?". Retrieving the DTO is part of that logic. Then the recall logic knows it has valid data, and it can update state immediately. If the parsing fails, the recall button won't be shown at all, so we avoid the awkward UX of "I pressed recall but there was an error". |
psychedelicious
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / Discussions
Closed #6130
QA Instructions
Merge Plan
Checklist