Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IdealSizeInvocation #6145

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Fix IdealSizeInvocation #6145

merged 1 commit into from
Apr 4, 2024

Conversation

JPPhoto
Copy link
Contributor

@JPPhoto JPPhoto commented Apr 4, 2024

Summary

IdealSizeInvocation failed to execute because get_config was not given a proper key from the passed-in UNet.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations labels Apr 4, 2024
@JPPhoto JPPhoto enabled auto-merge (squash) April 4, 2024 20:56
psychedelicious
psychedelicious approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I missed this JP. Thanks for fixing

@JPPhoto JPPhoto merged commit 3659219 into main Apr 4, 2024
14 checks passed
@JPPhoto JPPhoto deleted the JPPhoto-fix-idealsizeinvocation branch April 4, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

Assignees
No one assigned
Labels
invocations PRs that change invocations python PRs that change python files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JPPhoto @psychedelicious