Fix misplaced lock call in VRAM management routines (minor) #6153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lstein
requested review from
blessedcoolant,
GreggHelt2,
brandonrising,
RyanJDick and
hipsterusername
as code owners
github-actions
bot
added
python
lstein
changed the title
hipsterusername
approved these changes
Apr 5, 2024
psychedelicious
force-pushed
the
lstein/bugfix/fix-misplaced-lock-call
branch
from
2866f51
to
5a68207
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This corrects a small bug that would result in an additional exception after an OOM error occurred in the model manager. The only effect of the bug was on the log error messages.
Related Issues / Discussions
QA Instructions
Merge Plan
Merge when approved.
Checklist