fix(mm): premature insufficient VRAM reporting #6156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
lstein,
blessedcoolant,
GreggHelt2,
brandonrising,
RyanJDick and
hipsterusername
as code owners
github-actions
bot
added
python
hipsterusername
approved these changes
Apr 5, 2024
This check prematurely reports insufficient VRAM on Windows. See #6106 for details.
psychedelicious
force-pushed
the
psyche/fix/mm/remove-vram-check
branch
from
ba2274e
to
4473746
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Remove the new VRAM checking logic from the ModelCache, which prematurely reports insufficient VRAM on Windows.
See #6106 for details.
Related Issues / Discussions
Closes #6106
QA Instructions
Use the generation settings in #6106 on a 12GB GPU on Windows. That combination will trigger the premature OOM on
main, but will work on this branch (assuming the system has ~3GB free RAM).Merge Plan
n/a
Checklist