Fix regional prompt mask padding #6187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rror the downscaling behavior of SD and SDXL. Prior to this change, denoising with input latent dimensions that were not evenly divisible by 8 would raise an exception.
…o mirror the downscaling behavior of SD and SDXL. Prior to this change, denoising with input latent dimensions that were not evenly divisible by 8 would raise an exception.
RyanJDick
requested review from
lstein,
blessedcoolant,
GreggHelt2,
brandonrising and
hipsterusername
as code owners
github-actions
bot
added
python
blessedcoolant
approved these changes
Apr 9, 2024
hipsterusername
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a bug with regional prompting and regional IP-Adapter. Prior to this change, using regional prompts with input latent dimensions that aren't evenly divisible by 8 would raise an exception.
This issue was reported here: https://discord.com/channels/1020123559063990373/1049495067846524939/1227274512685338714
The root cause was that region mask downscaling did not mirror the downscaling padding behvaior of the SD/SDXL UNets.
QA Instructions
I tested the following:
Checklist