-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable multi deletion on keystroke #6216
Enable multi deletion on keystroke #6216
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple tweaks needed still
invokeai/frontend/web/src/features/deleteImageModal/components/DeleteImageButton.tsx
Outdated
Show resolved
Hide resolved
invokeai/frontend/web/src/features/deleteImageModal/components/DeleteImageButton.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks for fixing this. Good user experience enhancement!
Summary
Files modified:
invokeai/frontend/web/src/features/gallery/components/CurrentImage/CurrentImageButtons.tsx
invokeai/frontend/web/public/locales/en.json
invokeai/frontend/web/src/features/deleteImageModal/components/DeleteImageModal.tsx
Explanation
I modified the
CurrentImageButtons
script to create a variable that stores the current image selection and uses it as a dependency in thehandleDelete
method.Demo
demo-multi-delete.mp4
I also modified the
DeleteImageModal
to include the selection count as part of the modal title.Related Issues / Discussions
QA Instructions
delete
.Merge Plan
NA
Checklist