Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui): regional prompting followups #6247

Merged
merged 11 commits into from
Apr 20, 2024
Merged

feat(ui): regional prompting followups #6247

merged 11 commits into from
Apr 20, 2024

Conversation

psychedelicious
Copy link
Collaborator

Summary

  • Hook up SD1.5 graphs. HRF doesn't break, but I'm not sure if it really does what you want... I haven't attempted to integrate regions into HRF.
  • Fix undo history with layer color picker to group these changes
  • Less eye-stabbing default colors
  • Some perf improvements to bbox calculations
  • You can now select layers with the move tool to drag em around
Screen.Recording.2024-04-20.at.2.47.06.pm.mov

Related Issues / Discussions

n/a

QA Instructions

Have a play

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@psychedelicious
fix(ui): group layer color change history
cf9c117
@psychedelicious
fix(ui): give min dimensions to rp storybook
22e1d3b
@psychedelicious
perf(ui): more efficient bbox method with smaller minimum offscreen c…
e76ec4e 
…anvas size
@psychedelicious
perf(ui): more bbox optimizations
9896c68 
- Keep track of whether the bbox needs to be recalculated (e.g. had lines/points added)
- Keep track of whether the bbox has eraser strokes - if yes, we need to do the full pixel-perfect bbox calculation, otherwise we can use the faster getClientRect
- Use comparison rather than Math.min/max in bbox calculation (slightly faster)
- Return `null` if no pixel data at all in bbox
@psychedelicious
feat(ui): update move tool to show all bboxes, mouseover bbox strokes
8a4c0a4
@psychedelicious
perf(ui): use efficient group caching instead of a compositing rect
ce03c94 
Seems to be the same speed and it's less complex.
@psychedelicious
perf(ui): caching efficiency
0e9a37f
@psychedelicious
feat(ui): better rp colors
4c6e513
@psychedelicious
feat(ui): hook up sd1.5 t2i graph to regional prompts
bdb9684
@psychedelicious
fix(ui): fix bbox caching
025475b
@github-actions github-actions bot added the frontend PRs that change frontend files label Apr 20, 2024
@psychedelicious psychedelicious enabled auto-merge (rebase) April 20, 2024 04:53
@psychedelicious psychedelicious merged commit d582203 into main Apr 20, 2024
14 checks passed
@psychedelicious psychedelicious deleted the psyche/feat/ui/regional-prompting-2 branch April 20, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psychedelicious @hipsterusername