feat(ui): refactor Control Adapters in Control Layers #6298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion (wip) - Revise control adapter config types - Recreate all control adapter mutations in control layers slice - Bit of renaming along the way - typing 'RegionalGuidanceLayer' over and over again was getting tedious
When typing in a number into the w/h number inputs, if the number is less than the step, it appears the value of 0 is used. This is unexpected; it means Chakra isn't clamping the value correctly (or maybe our wrapper isn't clamping it). Add checks to never bail if the width or height value from the number input component is 0.
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
hipsterusername
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR resolves a number of issues caused by the control adapters implementation being shared between Control Layers and the other tabs. The needs of CL vs the rest of the app are different enough that a lot of brittle special handling was needed. Also, there were sync issues between control adapter state and layer state, causing errors when a control adapter was deleted.
The solution is to split the control adapters handling. Control Layers now have a wholly separate CA implementation. I refined a lot of the handling of CA while working on this new implementation. The other tabs' functionality is unchanged. This does mean the UX for control adapters in CL is different from the rest of the app, but that's just how it's will be until those tabs are migrated over.
User-facing changes:
Related Issues / Discussions
Closes #6297
Closes #6293
QA Instructions
Merge Plan
n/a
Checklist