Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): workflow edges not saved #6403

Merged
merged 2 commits into from
May 20, 2024

Conversation

psychedelicious
Copy link
Collaborator

Summary

Related Issues / Discussions

https://discord.com/channels/1020123559063990373/1149513625321603162/1241849984140447886

QA Instructions

  • Save and then load a workflow, its edges should be saved.
  • Collapse two connected nodes so their edges are in the collapsed state. Save and load the workflow, the collapsed edge state should be retained (e.g. grey line w/ a number over it if there were multiple edges).

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added the frontend PRs that change frontend files label May 19, 2024
@github-actions github-actions bot added api python PRs that change python files labels May 19, 2024
@psychedelicious psychedelicious force-pushed the psyche/fix/ui/save-workflow-edges branch from d55254f to f70ee68 Compare May 19, 2024 23:37
@psychedelicious psychedelicious enabled auto-merge (rebase) May 20, 2024 01:34
This prevents a minor visual bug where collapsed edges between collapsed nodes didn't display correctly on first load of a workflow.
@psychedelicious psychedelicious force-pushed the psyche/fix/ui/save-workflow-edges branch from f70ee68 to d14f37b Compare May 20, 2024 01:34
@psychedelicious psychedelicious merged commit 620ee28 into main May 20, 2024
14 checks passed
@psychedelicious psychedelicious deleted the psyche/fix/ui/save-workflow-edges branch May 20, 2024 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api frontend PRs that change frontend files python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants