Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): 'undefined' being used for metadata on uploaded images #6433

Merged
merged 1 commit into from
May 23, 2024
Merged

fix(ui): 'undefined' being used for metadata on uploaded images #6433

merged 1 commit into from
May 23, 2024

Conversation

psychedelicious
Copy link
Collaborator

Summary

TIL if you add undefined to a form data object, it gets stringified to 'undefined'. Whoops!

Related Issues / Discussions

n/a

QA Instructions

n/a

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added the frontend PRs that change frontend files label May 23, 2024
@blessedcoolant blessedcoolant merged commit c493628 into main May 23, 2024
14 checks passed
@blessedcoolant blessedcoolant deleted the psyche/fix/ui/undefined-string-for-metadata branch May 23, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blessedcoolant blessedcoolant blessedcoolant approved these changes

@maryhipp maryhipp Awaiting requested review from maryhipp maryhipp is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

Assignees
No one assigned
Labels
frontend PRs that change frontend files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@psychedelicious @blessedcoolant