Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#6333] Add clear_queue_on_startup config to clear problematic queues #6502

Merged
merged 1 commit into from
Jun 19, 2024
Merged

[#6333] Add clear_queue_on_startup config to clear problematic queues #6502

merged 1 commit into from
Jun 19, 2024

Conversation

steffy-lo
Copy link
Contributor

Summary

Simple fix to clear problematic queues on startups leading to crashes by adding empty_queue_on_startup config to invokeai.yaml

Related Issues / Discussions

Closes #6333

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added api python PRs that change python files services PRs that change app services labels Jun 9, 2024
@steffy-lo steffy-lo force-pushed the fix/startup-queue-crash branch 2 times, most recently from be3d2c4 to 0063dcb Compare June 9, 2024 12:56
psychedelicious
psychedelicious requested changes Jun 13, 2024
View reviewed changes
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! And sorry for the late review. I've requested some changes.

invokeai/app/services/config/config_default.py Outdated Show resolved Hide resolved
invokeai/app/services/session_queue/session_queue_sqlite.py Outdated Show resolved Hide resolved
invokeai/app/services/session_queue/session_queue_sqlite.py Outdated Show resolved Hide resolved
@steffy-lo steffy-lo force-pushed the fix/startup-queue-crash branch 3 times, most recently from dc896b2 to 5b6ef66 Compare June 18, 2024 02:24
@steffy-lo steffy-lo changed the title [#6333] Add empty_queue_on_startup config to clear problematic queues [#6333] Add clear_queue_on_startup config to clear problematic queues Jun 18, 2024
psychedelicious
psychedelicious requested changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! I just realized that the logging of the clear/prune result needs to be updated. Good to merge after that is fixed.

invokeai/app/services/session_queue/session_queue_sqlite.py Outdated Show resolved Hide resolved
@steffy-lo steffy-lo force-pushed the fix/startup-queue-crash branch 2 times, most recently from aab4e61 to 3f408c0 Compare June 18, 2024 21:32
psychedelicious
psychedelicious approved these changes Jun 19, 2024
View reviewed changes
Copy link
Collaborator

@psychedelicious psychedelicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@psychedelicious psychedelicious enabled auto-merge (rebase) June 19, 2024 01:28
@psychedelicious psychedelicious merged commit a43d602 into invoke-ai:main Jun 19, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psychedelicious psychedelicious psychedelicious approved these changes

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

@hipsterusername hipsterusername Awaiting requested review from hipsterusername hipsterusername is a code owner

Assignees
No one assigned
Labels
api python PRs that change python files services PRs that change app services
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[enhancement]: Add auto_start_queue or empty_queue_on_startup config setting
2 participants
@steffy-lo @psychedelicious