-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable even larger images with one simple torch.nn.functional.silu import #653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…port Fixes: File "stable-diffusion/ldm/modules/diffusionmodules/model.py", line 37, in nonlinearity return x*torch.sigmoid(x) RuntimeError: CUDA out of memory. Tried to allocate 1.56 GiB [..] Now up to 1536x1280 is possible on 8GB VRAM. Also remove unused SiLU class.
Just cuda or mps too? |
VRAM error only happens on cuda. On mps there might be a small speed benefit, but it only happens once at the end of generation. |
lstein
approved these changes
Sep 17, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing how much performance you're able to wring out of this code!
Tested on 12 GB P100 and worked as advertised.
afiaka87
pushed a commit
to afiaka87/lstein-stable-diffusion
that referenced
this pull request
Sep 19, 2022
…port (invoke-ai#653) Fixes: File "stable-diffusion/ldm/modules/diffusionmodules/model.py", line 37, in nonlinearity return x*torch.sigmoid(x) RuntimeError: CUDA out of memory. Tried to allocate 1.56 GiB [..] Now up to 1536x1280 is possible on 8GB VRAM. Also remove unused SiLU class.
afiaka87
pushed a commit
to afiaka87/lstein-stable-diffusion
that referenced
this pull request
Sep 19, 2022
…port (invoke-ai#653) Fixes: File "stable-diffusion/ldm/modules/diffusionmodules/model.py", line 37, in nonlinearity return x*torch.sigmoid(x) RuntimeError: CUDA out of memory. Tried to allocate 1.56 GiB [..] Now up to 1536x1280 is possible on 8GB VRAM. Also remove unused SiLU class.
afiaka87
pushed a commit
to afiaka87/lstein-stable-diffusion
that referenced
this pull request
Sep 19, 2022
…port (invoke-ai#653) Fixes: File "stable-diffusion/ldm/modules/diffusionmodules/model.py", line 37, in nonlinearity return x*torch.sigmoid(x) RuntimeError: CUDA out of memory. Tried to allocate 1.56 GiB [..] Now up to 1536x1280 is possible on 8GB VRAM. Also remove unused SiLU class.
afiaka87
pushed a commit
to afiaka87/lstein-stable-diffusion
that referenced
this pull request
Sep 21, 2022
…port (invoke-ai#653) Fixes: File "stable-diffusion/ldm/modules/diffusionmodules/model.py", line 37, in nonlinearity return x*torch.sigmoid(x) RuntimeError: CUDA out of memory. Tried to allocate 1.56 GiB [..] Now up to 1536x1280 is possible on 8GB VRAM. Also remove unused SiLU class.
austinbrown34
pushed a commit
to cognidesign/InvokeAI
that referenced
this pull request
Dec 30, 2022
…port (invoke-ai#653) Fixes: File "stable-diffusion/ldm/modules/diffusionmodules/model.py", line 37, in nonlinearity return x*torch.sigmoid(x) RuntimeError: CUDA out of memory. Tried to allocate 1.56 GiB [..] Now up to 1536x1280 is possible on 8GB VRAM. Also remove unused SiLU class.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes:
File "stable-diffusion/ldm/modules/diffusionmodules/model.py", line 37, in nonlinearity
return x*torch.sigmoid(x)
RuntimeError: CUDA out of memory. Tried to allocate 1.56 GiB [..]
Now up to 1536x1280 is possible on 8GB VRAM.
Also remove unused SiLU class.
silu
isx * torch.sigmoid(x)
is the swish functionhttps://pytorch.org/docs/stable/generated/torch.nn.functional.silu.html