Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modular backend - add rescale cfg #6640

Merged
merged 3 commits into from
Jul 23, 2024
Merged

Modular backend - add rescale cfg #6640

merged 3 commits into from
Jul 23, 2024

Conversation

StAlKeR7779
Copy link
Contributor

@StAlKeR7779 StAlKeR7779 commented Jul 21, 2024 •
edited
Loading

Summary

Rescale CFG code from #6577.

Related Issues / Discussions

#6606
https://invokeai.notion.site/Modular-Stable-Diffusion-Backend-Design-Document-e8952daab5d5472faecdc4a72d377b0d

QA Instructions

Run with and without set USE_MODULAR_DENOISE environment.
Note: for some reasons there slightly different output from run to run, but I able sometimes to get same output on main and this branch. Fix presented in #6641.

Merge Plan

Nope. Merge #6641 firstly, to be able see output difference properly.
If you think that there should be some kind of tests - feel free to add.

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations backend PRs that change backend files labels Jul 21, 2024
RyanJDick
RyanJDick reviewed Jul 22, 2024
View reviewed changes
Copy link
Collaborator

@RyanJDick RyanJDick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the following:

  • SD 1.5, CFG Rescale multiplier 0.0
  • SD 1.5, CFG Rescale multiplier: 0.99
  • SDXL, CFG Rescale multiplier 0.0
  • SDXL, CFG Rescale multiplier: 0.99

Just fix up the couple of minor comments, and this looks good to go.

invokeai/backend/stable_diffusion/extensions/rescale_cfg.py Outdated Show resolved Hide resolved
invokeai/backend/stable_diffusion/extension_callback_type.py Show resolved Hide resolved
@StAlKeR7779 @RyanJDick
Suggested changes
1b359b5 
Co-Authored-By: Ryan Dick <14897797+RyanJDick@users.noreply.github.com>
@RyanJDick RyanJDick enabled auto-merge July 23, 2024 13:34
@RyanJDick RyanJDick merged commit de39c5e into invoke-ai:main Jul 23, 2024
14 checks passed
@StAlKeR7779 StAlKeR7779 deleted the stalker7779/modular_rescale_cfg branch July 23, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hipsterusername hipsterusername hipsterusername approved these changes

@RyanJDick RyanJDick RyanJDick approved these changes

@lstein lstein Awaiting requested review from lstein lstein is a code owner

@blessedcoolant blessedcoolant Awaiting requested review from blessedcoolant blessedcoolant is a code owner

@brandonrising brandonrising Awaiting requested review from brandonrising brandonrising is a code owner

@psychedelicious psychedelicious Awaiting requested review from psychedelicious psychedelicious is a code owner

Assignees
No one assigned
Labels
backend PRs that change backend files invocations PRs that change invocations python PRs that change python files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@StAlKeR7779 @RyanJDick @hipsterusername