Split LoRA layer implementations into separate files. #6845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RyanJDick
requested review from
lstein,
blessedcoolant,
brandonrising,
hipsterusername and
psychedelicious
as code owners
github-actions
bot
added
python
maryhipp
approved these changes
Sep 12, 2024
brandonrising
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR splits the lora.py monolith into separate files. The main motivation for doing this in a standalone PR is to make the diffs more interpretable in the upcoming changes to support LoRAs for FLUX.
This PR does not make any functional changes - it just moves files around and changes import paths.
QA Instructions
I smoke tested generation with LoRA, LoHA, LoKr, and IA3.
Merge Plan
No special instructions. Merge on approval.
Checklist