perf(ui): rendering optimizations #7061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
hipsterusername
approved these changes
Oct 9, 2024
psychedelicious
force-pushed
the
psyche/feat/ui/bbox-calculations
branch
from
752e2b7
to
6d9e144
Compare
…eviews Instead of pulling the preview canvas from the konva internals, use the canvas created for bbox calculations as the preview canvas. This doesn't change perf characteristics, because we were already creating this canvas. It just means we don't need to dip into the konva internals. It fixes an issue where the layer preview didn't update or show when a layer is disabled or otherwise hidden.
This feature involves a certain amount of extra work to ensure stroke and fill with partial opacity render correctly together. However, none of our shapes actually use that combination of attributes, so we can disable this for a minor perf boost.
- Throttle opacity and compositing fill rendering to 100ms - Reduce compositing rect rendering to minimum
Reduce confusion w/ the many other caches
psychedelicious
force-pushed
the
psyche/feat/ui/bbox-calculations
branch
from
6d9e144
to
7737212
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Handful of optimizations implemented while attempting to get a performant full canvas preview (unfortunately unsuccessful).
Related Issues / Discussions
Closes #6950
QA Instructions
Have a play, should be no change to behaviour. I think I can feel it is a bit snappier but could be wishful thinking.
Merge Plan
n/a
Checklist