refactor(ui): modals state, workflow list modal misc #7087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
github-actions
bot
added
frontend-deps
hipsterusername
approved these changes
Oct 10, 2024
- Tooltips on buttons for a list item getting stuck - List item action buttons should not propagate clicks
Brings in a fix where ConfirmationAlertDialog rest props weren't used correctly.
The component state is a global singleton, but each workflow had an instance of the modal. So when you open one, they _all_ opened.
…estore new workflow dialog
…, or it opens unexpectedly - When resetting workflows, retain the current mode state - Remove the useEffect that reacted to the `isCleanEditor` flag to prevent getting menu getting locked open
footgun insurance
hipsterusername
force-pushed
the
psyche/refactor/ui/modals-misc
branch
from
28c725a
to
8a842a3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Started addressing some issues w/ workflows list modal and had to make some deeper changes:
useAssertSingletonto all singleton modals. In case we accidentally render a singleton modal twice, we'll get an error immediately.buildUseBoolean, but with the semantics of disclosure state. For example,isOpenvsisTrue,open()vssetTrue().@invoke-ai/ui-librarywhere the confirmation dialog didn't spread its...restprops correctly. This fixes some stragglers for a perf issue that I had intended to fix in ace8794.Related Issues / Discussions
scattered discord feedback and offline discussion
QA Instructions
Have a play w/ the menu. There should be only minor user-facing changes, specifically the clear workflow button is now a new workflow button.
Merge Plan
n/a
Checklist