feat(ui): updates to Layers and Gallery tabs #7119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maryhipp
requested review from
psychedelicious,
blessedcoolant and
hipsterusername
as code owners
maryhipp
changed the title
psychedelicious
force-pushed
the
maryhipp/canvas-panel-tabs-to-persistent-state
branch
from
d61f0cd
to
535c128
Compare
psychedelicious
force-pushed
the
maryhipp/canvas-panel-tabs-to-persistent-state
branch
from
19bfa60
to
175c335
Compare
…oss sessions/refreshes, make gallery the default
…ragging from gallery to layers tabs
…UX for dragging from gallery to layers tabs" This reverts commit 535c128.
We can use the drop overlay component directly for this, without needing to add it as a `noop` dnd target. Other changes: - The `label` prop is now used to conditionally render the label - every drop target provides its own label, so this doesn't break anything. - Add `withBackdrop` prop to control whether we apply the dimmed drop target effect.
psychedelicious
force-pushed
the
maryhipp/canvas-panel-tabs-to-persistent-state
branch
from
175c335
to
f0f357f
Compare
psychedelicious
approved these changes
Oct 16, 2024
psychedelicious
deleted the
maryhipp/canvas-panel-tabs-to-persistent-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
44cc25a: Move the tab state for layers/gallery (canvas right panel) into redux so that it persists across session/refreshes. Also make gallery the default so that it appears for new users or those who do not have client-side state yet.
d61f0cd: add layers tab as droppable destination to improve UX of dragging an image from gallery to an existing layer
Related Issues / Discussions
QA Instructions
Screen.Recording.2024-10-15.at.10.39.33.AM.mov
Merge Plan
Checklist