Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: canvas auto mask followups 5 #7196

Merged
merged 10 commits into from
Oct 25, 2024

Conversation

psychedelicious
Copy link
Collaborator

@psychedelicious psychedelicious commented Oct 25, 2024

Summary

  • Rename Auto-Mask to Select Object.
  • Change icon to shapes (open to suggestions - this is easily recognizable even at a small size):
    image
  • Add invert selection functionality via new field on the apply_tensor_mask_to_image node. This is by far the simplest way to support inverted selection. When the selection is inverted, it takes the size of the input layer. Demo:
    Screen.Recording.2024-10-25.at.5.11.18.pm.mov
  • Increase size of layer toolbar icons slightly.
  • Change filter icon to the "fill" variant, which has the same shape but is just a bit easier to recognize.
  • Change the filter & select object Process buttons to use the "play" icon.
  • Add Replace Current option to Select Object's Save As menu. Also upgraded Filter to have the same menu.
    image

Related Issues / Discussions

offline discussion

QA Instructions

  • Happy with the name Select Object?
  • Happy with the "shapes" icon?
  • Happy with the invert functionality?

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

@github-actions github-actions bot added python PRs that change python files invocations PRs that change invocations frontend PRs that change frontend files labels Oct 25, 2024
@hipsterusername hipsterusername merged commit 008be9b into main Oct 25, 2024
14 checks passed
@hipsterusername hipsterusername deleted the psyche/feat/canvas-auto-mask-followups-5 branch October 25, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files invocations PRs that change invocations python PRs that change python files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants