feat(ui): canvas auto mask followups 6 #7203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Restore dedicated `Apply` buttons - Remove icons from the buttons, too much noise when the words are short and clear - Update loading state to show a spinner next to the `Process` button instead of on _every_ button
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
hipsterusername
approved these changes
Oct 26, 2024
hipsterusername
deleted the
psyche/feat/ui/canvas-auto-mask-followups-6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issues / Discussions
offline discussion
QA Instructions
Canvas ctx menu:
Screen.Recording.2024-10-26.at.12.01.48.pm.mov
Image ctx menu:
Screen.Recording.2024-10-26.at.12.02.40.pm.mov
Filter/Select Object/Transform UI (Select Object shown, with same changes for the others):
Screen.Recording.2024-10-26.at.12.02.20.pm.mov
Merge Plan
stable release after this
Checklist