-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust pins for torch, numpy, other dependencies #7232
Conversation
Testing on MPS:
|
On MPS, it would be good to test with Thanks for confirming that |
@ebr worked great on windows with extra index cu124 |
…isfy stricted dependency resolution
b39e72d
to
558c4b3
Compare
Summary
Dependency resolution by
pip
is fairly lax, and allows fallback to the main PyPi index in case a matching distribution cannot be found. As we're working on an improved installation experience, this is becoming a blocker for installing Invoke using other tools, such asuv
. Also, this work exposed some spots where some transitive dependencies might be overridden in spite of different version requirements by direct dependencies (e.g.requests
was pinned to a version that is no longer valid).This PR makes the minimal adjustments to the dependency pins, just to satisfy all direct dependencies and allow the package to be installed.
QA Instructions
This is best tested using a tool that has follows strict dependency resolution rules, such as Astral's
uv
: https://github.com/astral-sh/uv. Install it prior to testing, then run the following, adjusting paths as necessary:Merge Plan
Merge when sufficiently tested on the following platforms / pytorch indices:
windows
--extra-index-url https://download.pytorch.org/whl/cu124
--extra-index-url https://download.pytorch.org/whl/cpu
linux
--extra-index-url https://download.pytorch.org/whl/cu124
--extra-index-url https://download.pytorch.org/whl/cpu
macOS
--extra-index-url https://download.pytorch.org/whl/cpu
Checklist