refactor(ui): layer interaction locking #7234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psychedelicious
requested review from
blessedcoolant,
maryhipp and
hipsterusername
as code owners
hipsterusername
approved these changes
Oct 31, 2024
Previously we maintained an `isInteractable` flag, which was derived from these layer flags: - Locked/unlocked - Enabled/disabled - Layer's type visible/hidden When a layer was not interactable, we blocked all layer actions. After comparing to the behaviour in Affinity and considering user feedback, I've loosened these restrictions while maintaining safety. First, some definitions. There two kinds of layer actions - mutating actions and non-mutating actions. - Mutating actions are drawing on the layer, cropping it, filtering it, converting it, etc. Anything that changes the layer. - Non-mutating actions are copying the layer, saving the layer to gallery, etc. Anything that _uses_ the layer. Then, there are two broad canvas states - busy and not busy. "Busy" means the canvas is actively filtering, staging, compositing layers together, etc - something that is "single-threaded" by nature. And here are the revised restrictions: - When canvas is busy, you cannot initiate any layer actions. - When the canvas is not busy, and the layer is locked, you initiate any mutating actions. - When the canvas is not busy and the layer is not locked, you can initiate any layer action. Besides safely giving users more freedom, it also fixes an issue where the context menu for a layer was disabled if it was not the selected layer.
psychedelicious
force-pushed
the
psyche/fix/ui/canvas-misc
branch
from
5c58e6e
to
b1b2419
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously we maintained an
isInteractableflag, which was derived from these layer flags:When a layer was not interactable, we blocked all layer actions.
After comparing to the behaviour in Affinity and considering user feedback, I've loosened these restrictions while maintaining safety. First, some definitions.
There two kinds of layer actions - mutating actions and non-mutating actions.
Then, there are two broad canvas states - busy and not busy. "Busy" means the canvas is actively filtering, staging, compositing layers together, etc - something that is "single-threaded" by nature.
And here are the revised restrictions:
Besides safely giving users more freedom, it also fixes an issue where the context menu for a layer was disabled if it was not the selected layer.
Related Issues / Discussions
https://discord.com/channels/1020123559063990373/1149506274971631688/1301195129570201680
QA Instructions
Test out combinations of the restrictions. There are a lot of permutations.
Merge Plan
n/a
Checklist