Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): filter/select-object do not exit on save-as #7238

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

psychedelicious
Copy link
Collaborator

Summary

  • When using save-as with filter/select-object, do not exit the filter/select-object. This facilitates common workflows that want to use the output of these features for multiple layers.
  • Fix a bug that is exacerbated by this change that causes inpaint mask and regional guidance layers not rendering correctly.

Related Issues / Discussions

https://discord.com/channels/1020123559063990373/1020123559831539744/1301301721565233172

QA Instructions

Try save-as when filtering/select-object-ing. Mask layers should render as expected when you exit filter or select-object.

Merge Plan

n/a

Checklist

  • The PR has a short but descriptive title, suitable for a changelog
  • Tests added / updated (if applicable)
  • Documentation added / updated (if applicable)

This fixes an issue uncovered by the previous commit in which we do not exit filter/select-object on save-as.
@github-actions github-actions bot added the frontend PRs that change frontend files label Oct 31, 2024
@hipsterusername hipsterusername merged commit e032ab1 into main Oct 31, 2024
14 checks passed
@hipsterusername hipsterusername deleted the psyche/fix/ui/canvas-save-as-new-layer branch October 31, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend PRs that change frontend files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants