-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SD3 Image-to-Image and Inpainting #7295
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the diffusers FlowMatchEulerDiscreteScheduler. It is easier to work with and enables us to re-use the clip_timestep_schedule_fractional() utility from FLUX.
RyanJDick
requested review from
lstein,
blessedcoolant,
brandonrising,
hipsterusername and
psychedelicious
as code owners
November 7, 2024 23:03
github-actions
bot
added
python
PRs that change python files
invocations
PRs that change invocations
backend
PRs that change backend files
labels
Nov 7, 2024
…i/InvokeAI into ryan/sd3-image-to-image
I ran through the tests listed in the PR description. Everything works, although inpainting/outpainting quality with SD3 is clearly worse than other model architectures (SD1, SDXL, FLUX). (The example in the PR description is cherry-picked.) I think it's ok to merge, but we may want to loop back and spend more time iterating on the inpainting implementation at some point. |
maryhipp
approved these changes
Nov 13, 2024
psychedelicious
approved these changes
Nov 14, 2024
hipsterusername
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backend
PRs that change backend files
frontend
PRs that change frontend files
invocations
PRs that change invocations
python
PRs that change python files
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support for SD3 image-to-image and inpainting. Similar to FLUX, the implementation supports fractional denoise_start/denoise_end for more fine-grained denoise strength control, and a gradient mask adjustment schedule for smoother inpainting seams.
Example
Workflow
Result
QA Instructions
Merge Plan
Checklist
What's New
copy (if doing a release after this PR)