Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add TemSen property to receive current room temperature #11

Merged
merged 2 commits into from
Jun 4, 2020

Conversation

aivus
Copy link
Contributor

@aivus aivus commented Jun 3, 2020

I've found that HVAC returns the info of the current temperature. Seems it has internal sensor.
Room temperature is received using TemSen property and the value has offset of +40.
I believe it's because they are using unsigned data type.

The same approach is used in https://github.com/ddenisyuk/homebridge-gree-heatercooler/blob/3979fc6dad9d1935c59c686eb1764a062246ee7c/index.js#L224-L226

This PR was verified in https://github.com/aivus/com.gree

{
  t: 'dat',
  mac: 'ffffffffffff',
  r: 200,
  cols: [
    'Pow',    'Mod',
    'TemUn',  'SetTem',
    'TemSen', 'WdSpd',
    'Air',    'Blo',
    'Health', 'SwhSlp',
    'Lig',    'SwingLfRig',
    'SwUpDn', 'Quiet',
    'Tur',    'SvSt'
  ],
  dat: [
    0, 1, 0, 24, 65, 1,
    0, 0, 0,  0,  1, 0,
    6, 0, 0,  0
  ]
}

Also I've added readOnly option to this property to prevent set requests to HVAC.

aivus added 2 commits June 3, 2020 13:42
…ture

AC returns temperature+40. I believe it's because it has unsigned data type
When TemSen=0 it means real temperature is -40 degrees
@inwaar inwaar merged commit dd163cc into inwaar:master Jun 4, 2020
@inwaar
Copy link
Owner

inwaar commented Jun 4, 2020

Thanks for the request.

My HVAC just gives 0 for this property. So supposedly this needs to be supported by the device.
I refactored a bit some parts and If you could check if the master works for you I could create a new release soon.

@aivus
Copy link
Contributor Author

aivus commented Jun 4, 2020 via email

@aivus
Copy link
Contributor Author

aivus commented Jun 5, 2020

I've tested master version and it works like a charm.

My hvac doesn't show current temperature not in EWPE, nor on remote control.

I remembered that my HVAC can show current temperature on built-in screen using TEMP button:
image

I've create another PR with additional test case which covers your changes (TemSen=0) and updated a property list in readme files: #12

@aivus
Copy link
Contributor Author

aivus commented Jun 12, 2020

@inwaar could you please release a new version?

@inwaar
Copy link
Owner

inwaar commented Jun 15, 2020

I remembered that my HVAC can show current temperature on built-in screen using TEMP button:

Yes, my device is showing it on LED display and even outdoor temperature but not in API for some reason.

btw, the package 1.3.1 is available

@k8ieone
Copy link

k8ieone commented Jul 1, 2020

Yes, my device is showing it on LED display and even outdoor temperature but not in API for some reason.

Same here. The display can be set to display the current temperature yet the API always shows 0.

@k8ieone
Copy link

k8ieone commented Jul 1, 2020

Interesting... After a firmware "upgrade" from 3.7 to 2.5 the AC started reporting the temperature. Also +40 offset.

@inwaar
Copy link
Owner

inwaar commented Jul 1, 2020

Interesting... After a firmware "upgrade" from 3.7 to 2.5 the AC started reporting the temperature. Also +40 offset.

Hi, how did you downgrade the firmware?
What the model of AC btw?

@k8ieone
Copy link

k8ieone commented Jul 1, 2020

Sinclair MV-H07BIF. The Gree Smart app can be used for controlling Sinclair ACs. They have their own app (basically a clone), biggest difference being in that if you want to connect the AC to WiFi, you have to create an account.

Gree's app showed the latest firmware is 3.7 and Sinclair's app (WiFi Smart) showed the latest being 2.5. My AC came with 3.7.

I used Gree's app to connect the AC to WiFi without making an account and then updated the firmware with Sinclair's app.

I think the firmwares should be cross-compatible (can't be sure tho). The feature-set and the way the AC communicates is exactly the same as Gree.

@xuefer
Copy link

xuefer commented Nov 27, 2020

there's no +40°C offset reported by V4 firmware from gree+ app (iOS)

https://github.com/tomikaa87/gree-remote.git
# cd gree-remote/PythonCLI
# ./get TemSen
gree.py -c 192.168.26.72 -i 77a8ba4a -k ... get TemSen
Getting parameter: TemSen
TemSen = 25

gree.py -c 192.168.26.73 -i 77dd30f3 -k ... get TemSen
Getting parameter: TemSen
TemSen = 26

gree.py -c 192.168.26.74 -i a70f1fa6 -k ... get TemSen
Getting parameter: TemSen
TemSen = 26

gree.py -c 192.168.26.75 -i a7102045 -k ... get TemSen
Getting parameter: TemSen
TemSen = 24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants