Remove private messages after specific cache duration #1333
Conversation
This will not affect messages in the 'archive' folder.
Please also coordinate this with the uu.de team members, as this change will have an impact on the documentation of communication between team members with users |
I will, definitely before the next release. Could an option also be to disable this by default for team members? |
Could be a suitable mitigation, yes. But I wonder why deleting the messages from Inbox and Sent is necessary in the first place. |
The contents of most messages should be fairly trivial, in most cases; probably they are never again looked at, and all take space. More important material can still be archived. |
There was a problem hiding this comment.
Additionally, to the inline comments: is_team_member exists, if messages should not be deleted for them.
| has been reached. | ||
| """ | ||
| privmsgs_trash = PrivateMessageEntry.objects.filter( | ||
| folder="2", |
There was a problem hiding this comment.
i would suggest to remove magic numbers (and instead use a constant in the model f.e.)
| after end of cache duration according to settings | ||
| has been reached. | ||
| """ | ||
| privmsgs_trash = PrivateMessageEntry.objects.filter( |
There was a problem hiding this comment.
I's better to move logic out of @shared_task, to for example two methods in the model manger. So the shared task would only call these two (plus the logger)
This will make it possible to add some basic tests (for example: are only old messages are deleted? are messages in archive are kept? ...)
|
I'll come back to this soon, sorry, I was quite busy with other things lately. |
This will not affect messages in the 'archive' folder. Closes #372. Probably also a configuration option should be created for this, in case users want to disable it? At least there'll have to be an announcement for the changed behaviour.