This repository has been archived by the owner on Nov 28, 2019. It is now read-only.
View parameters store callback per Parameterized instance #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to need another release once this is merged. |
jbednar
approved these changes
May 9, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug took me ages to figure out. The View parameters have a
callbackattribute which allows them to be called in response to a__set__event. Since a Parameter is instantiated once per Parameterized class all the instances of the Parameterized class will share the same view parameters and therefore the callback will be overridden for each set of widgets that is displayed. This means if you use param.Widgets on the same class or a subclass any previous displayed plots will update the newly displayed viewing area rather than the old one. This PR adds a callbacks dictionary, which allows registering callbacks by theidof the Parameterized instance so widgets for multiple instances can be displayed and updated independently.