Vertically center iOS text if lineHeight is set

Summary: First PR!! This fixes facebook#2991 :) Closes facebook#7603 Differential Revision: D3417257 fbshipit-source-id: 074d56c1dfc0a9ba713e59c804286fd915589eeb
iodine · Aug 23, 2016 · 5097d17 · 5097d17
1 parent 107778d
commit 5097d17
Showing 1 changed file with 8 additions and 0 deletions.
diff --git a/Libraries/Text/RCTShadowText.m b/Libraries/Text/RCTShadowText.m
@@ -369,6 +369,14 @@ - (void)_setParagraphStyleOnAttributedString:(NSMutableAttributedString *)attrib
     }
     paragraphStyle.minimumLineHeight = lineHeight;
     paragraphStyle.maximumLineHeight = lineHeight;
+
+    // vertically center text
+    CGFloat fontSize = _fontSize && !isnan(_fontSize) ? _fontSize : UIFont.systemFontSize;
+    fontSize *= fontSizeMultiplier;
+
+    [attributedString addAttribute:NSBaselineOffsetAttributeName
+                             value:@(lineHeight/2 - fontSize/2)
+                             range:(NSRange){0, attributedString.length}];
     [attributedString addAttribute:NSParagraphStyleAttributeName
                              value:paragraphStyle
                              range:(NSRange){0, attributedString.length}];