Skip to content

Commit

Permalink
chore(cli): Update minimum deployment target to 14.0 (#7681)
Browse files Browse the repository at this point in the history
  • Loading branch information
jcesarmobile authored Oct 2, 2024
1 parent 8e11231 commit 10490f1
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 19 deletions.
2 changes: 1 addition & 1 deletion cli/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -331,7 +331,7 @@ async function loadIOSConfig(

return {
name,
minVersion: '13.0',
minVersion: '14.0',
platformDir,
platformDirAbs,
scheme,
Expand Down
15 changes: 0 additions & 15 deletions cli/src/ios/update.ts
Original file line number Diff line number Diff line change
Expand Up @@ -122,21 +122,6 @@ async function updatePodfile(
/(require_relative)[\s\S]+?(@capacitor\/ios\/scripts\/pods_helpers')/,
`require_relative '${relativeCapacitoriOSPath}/scripts/pods_helpers'`,
);
podfileContent = podfileContent.replace(
`def assertDeploymentTarget(installer)
installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
# ensure IPHONEOS_DEPLOYMENT_TARGET is at least 13.0
deployment_target = config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'].to_f
should_upgrade = deployment_target < 13.0 && deployment_target != 0.0
if should_upgrade
config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '13.0'
end
end
end
end`,
`require_relative '${relativeCapacitoriOSPath}/scripts/pods_helpers'`,
);
await writeFile(podfilePath, podfileContent, { encoding: 'utf-8' });

const podPath = await config.ios.podPath;
Expand Down
6 changes: 3 additions & 3 deletions ios/scripts/pods_helpers.rb
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
def assertDeploymentTarget(installer)
installer.pods_project.targets.each do |target|
target.build_configurations.each do |config|
# ensure IPHONEOS_DEPLOYMENT_TARGET is at least 13.0
# ensure IPHONEOS_DEPLOYMENT_TARGET is at least 14.0
deployment_target = config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'].to_f
should_upgrade = deployment_target < 13.0 && deployment_target != 0.0
should_upgrade = deployment_target < 14.0 && deployment_target != 0.0
if should_upgrade
config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '13.0'
config.build_settings['IPHONEOS_DEPLOYMENT_TARGET'] = '14.0'
end
end
end
Expand Down

0 comments on commit 10490f1

Please sign in to comment.