feat(cli): add inline option to copy command (#5901)

* feat(cli): add inline option to copy command * chore: fix update default passed to copy * chore: make inlines optional with false default
ionic-team · Sep 7, 2022 · 17fbabb · 17fbabb
1 parent d84352d
commit 17fbabb
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 11 deletions.
diff --git a/cli/src/index.ts b/cli/src/index.ts
@@ -122,12 +122,17 @@ export function runProgram(config: Config): void {
   program
     .command('copy [platform]')
     .description('copies the web app build into the native app')
+    .option(
+      '--inline',
+      'Optional: if true, all source maps will be inlined for easier debugging on mobile devices',
+      false,
+    )
     .action(
       wrapAction(
-        telemetryAction(config, async platform => {
+        telemetryAction(config, async (platform, { inline }) => {
           checkExternalConfig(config.app);
           const { copyCommand } = await import('./tasks/copy');
-          await copyCommand(config, platform);
+          await copyCommand(config, platform, inline);
         }),
       ),
     );

diff --git a/cli/src/tasks/copy.ts b/cli/src/tasks/copy.ts
@@ -23,9 +23,12 @@ import { getPlugins } from '../plugin';
 import { allSerial } from '../util/promise';
 import { copyWeb } from '../web/copy';
 
+import { inlineSourceMaps } from './sourcemaps';
+
 export async function copyCommand(
   config: Config,
   selectedPlatformName: string,
+  inline = false,
 ): Promise<void> {
   if (selectedPlatformName && !(await isValidPlatform(selectedPlatformName))) {
     const platformDir = resolvePlatform(config, selectedPlatformName);
@@ -43,7 +46,7 @@ export async function copyCommand(
     const platforms = await selectPlatforms(config, selectedPlatformName);
     try {
       await allSerial(
-        platforms.map(platformName => () => copy(config, platformName)),
+        platforms.map(platformName => () => copy(config, platformName, inline)),
       );
     } catch (e) {
       if (isFatal(e)) {
@@ -58,6 +61,7 @@ export async function copyCommand(
 export async function copy(
   config: Config,
   platformName: string,
+  inline = false,
 ): Promise<void> {
   await runTask(c.success(c.strong(`copy ${platformName}`)), async () => {
     const result = await checkWebDir(config);
@@ -134,6 +138,9 @@ export async function copy(
     } else {
       throw `Platform ${platformName} is not valid.`;
     }
+    if (inline) {
+      await inlineSourceMaps(config, platformName);
+    }
   });
 
   await runPlatformHook(

diff --git a/cli/src/tasks/sync.ts b/cli/src/tasks/sync.ts
@@ -12,7 +12,6 @@ import { logger } from '../log';
 import { allSerial } from '../util/promise';
 
 import { copy, copyCommand } from './copy';
-import { inlineSourceMaps } from './sourcemaps';
 import { update, updateChecks, updateCommand } from './update';
 
 /**
@@ -22,11 +21,11 @@ export async function syncCommand(
   config: Config,
   selectedPlatformName: string,
   deployment: boolean,
-  inline: boolean,
+  inline = false,
 ): Promise<void> {
   if (selectedPlatformName && !(await isValidPlatform(selectedPlatformName))) {
     try {
-      await copyCommand(config, selectedPlatformName);
+      await copyCommand(config, selectedPlatformName, inline);
     } catch (e) {
       logger.error(e.stack ?? e);
     }
@@ -62,7 +61,7 @@ export async function sync(
   config: Config,
   platformName: string,
   deployment: boolean,
-  inline: boolean,
+  inline = false,
 ): Promise<void> {
   await runPlatformHook(
     config,
@@ -72,10 +71,7 @@ export async function sync(
   );
 
   try {
-    await copy(config, platformName);
-    if (inline) {
-      await inlineSourceMaps(config, platformName);
-    }
+    await copy(config, platformName, inline);
   } catch (e) {
     logger.error(e.stack ?? e);
   }