chore(cli): Autodetect Android Studio path on Windows

[ralscha]

Auto Detect Android Studio path on Windows by reading a Windows registry entry.

First checks if path in windowsAndroidStudioPath exist.
If not it tries to read the Windows registry entry HKEY_LOCAL_MACHINE\\SOFTWARE\\Android Studio

Issues #560 and #230

Based on getASPath.bat
https://github.com/apache/cordova-android/blob/master/bin/templates/cordova/lib/getASPath.bat

[Genarito]

Excuse me, It would not be better to check first if the current platform is Windows before executing the retrieval of the path and if sentences?

private initWindowsConfig() {
    if (this.cli.os !== OS.Windows) {
        return;
    }

    // Your code (without checking cli again in the second if)...
}

[ralscha]

I guess this could work too. In that case this.windows.androidStudioPath is undefined, but I guess this does not matter when you don't run it on Windows.

The current code always sets this.windows.androidStudioPath with the value from this.app.windowsAndroidStudioPath

Current version:

this.windows.androidStudioPath = this.app.windowsAndroidStudioPath && this.app.windowsAndroidStudioPath;

[jcesarmobile]

Proposed two changes.
Other than that works fine and looks good.

[jcesarmobile]

can you put the this.cli.os === OS.Windows first? in that case it won't try to see if the file exists in non windows. Or even as @Genarito proposed as it doesn't matter if it's not set in other platforms different from windows.

[ralscha]

An alternative is to switch the comparison inside the if
If the first operand is false, JavaScript will short-circuit and not evaluate the second condition.

if (this.cli.os === OS.Windows && !existsSync(this.app.windowsAndroidStudioPath)) {

[jcesarmobile]

Yeah, that's what I meant when I said first, in the same if, but it's also ok to just do nothing if it's not windows as Genarito suggested.

[jcesarmobile]

can you put all this in a try catch?
If Android Studio is not installed it shows an ugly message because it doesn't find the registry.
In the catch you can set the path to empty string so it can be used later in the open command to not open if it's empty. I'll do that in a separate PR once this is merged.

[jcesarmobile]

nice, thanks!