fix(cordova): Don't add as system library if it's a vendored library #2729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imhoffd
reviewed
Apr 8, 2020
| @@ -340,6 +341,11 @@ function filterARCFiles(plugin: Plugin) { | |||
| return sourcesARC.length > 0; | |||
| } | |||
|
|
|||
| function removeNoSystem(library: string, sourceFrameworks: Array<string>) { | |||
There was a problem hiding this comment.
I think we should start preferring this syntax for TS arrays. Thoughts?
Suggested change
| function removeNoSystem(library: string, sourceFrameworks: Array<string>) { | |
| function removeNoSystem(library: string, sourceFrameworks: string[]) { |
There was a problem hiding this comment.
I have no preference on one syntax over the other, but yeah, we should decide one or the other and always use the same.
Won't change it for now, but we can do a refactor later that replaces all of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only system libraries should be added to libraries section, but since it's hard to know if the library is a system library or not, at least don't include a library in libraries section if it's also on vendored_libraries section
closes #2642