Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(android): share both text and url at the same time #3233

Merged
merged 2 commits into from
Jul 9, 2020
Merged

feat(android): share both text and url at the same time #3233

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b28ed26
feat(android): share both text and url at the same time
nikosdouvlis Jul 9, 2020
fa1c224
Merge branch 'master' into share-text-and-url-on-android
imhoffd Jul 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 26 additions & 16 deletions android/capacitor/src/main/java/com/getcapacitor/plugin/Share.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,27 +27,29 @@ public void share(PluginCall call) {
call.error("Must provide a URL or Message");
return;
}

if(url != null && !isFileUrl(url) && !isHttpUrl(url)) {
call.error("Unsupported url");
return;
}

Intent intent = new Intent(Intent.ACTION_SEND);

if (text != null) {
// If they supplied both fields, concat em
if (url != null && url.startsWith("http")) {
text = text + " " + url;
}
if (url != null && isHttpUrl(url)) text = text + " " + url;
intent.putExtra(Intent.EXTRA_TEXT, text);
intent.setTypeAndNormalize("text/plain");
} else if (url != null) {
if (url.startsWith("http")) {
intent.putExtra(Intent.EXTRA_TEXT, url);
intent.setTypeAndNormalize("text/plain");
} else if (url.startsWith("file:")) {
String type = getMimeType(url);
intent.setType(type);
Uri fileUrl = FileProvider.getUriForFile(getActivity(), getContext().getPackageName() + ".fileprovider", new File(Uri.parse(url).getPath()));
intent.putExtra(Intent.EXTRA_STREAM, fileUrl);
} else {
call.error("Unsupported url");
return;
}
}

if(url != null && isHttpUrl(url) && text == null) {
intent.putExtra(Intent.EXTRA_TEXT, url);
intent.setTypeAndNormalize("text/plain");
} else if (url != null && isFileUrl(url)) {
String type = getMimeType(url);
intent.setType(type);
Uri fileUrl = FileProvider.getUriForFile(getActivity(), getContext().getPackageName() + ".fileprovider", new File(Uri.parse(url).getPath()));
intent.putExtra(Intent.EXTRA_STREAM, fileUrl);
}

if (title != null) {
Expand All @@ -69,4 +71,12 @@ private String getMimeType(String url) {
}
return type;
}

private boolean isFileUrl(String url) {
return url.startsWith("file:");
}

private boolean isHttpUrl(String url) {
return url.startsWith("http");
}
}