Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): compatibility with cordova kotlin plugins #5438

Merged
merged 12 commits into from
Feb 21, 2022
Merged

fix(android): compatibility with cordova kotlin plugins #5438

merged 12 commits into from
Feb 21, 2022

Conversation

IT-MikeS
Copy link
Contributor

This PR allows supported Cordova plugins written in Kotlin to be used by capacitor-cordova-android-plugins.

@LifeIsStrange
Copy link

How does it compare to #4536 ?
Anyways it's about time for capacitor to get support for Kotlin cordova plugins..

jcesarmobile
jcesarmobile requested changes Feb 15, 2022
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be done in a way that the CLI adds this properties/dependencies if there is a plugin installed that uses kotlin

also the versions should be configurable from the variables.gradle instead of using hardcoded values

@IT-MikeS IT-MikeS marked this pull request as draft February 15, 2022 19:56
@IT-MikeS IT-MikeS marked this pull request as ready for review February 16, 2022 17:37
jcesarmobile
jcesarmobile requested changes Feb 16, 2022
View reviewed changes
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few comments

ios/Capacitor/Capacitor/WebViewDelegationHandler.swift Outdated Show resolved Hide resolved
cli/src/android/update.ts Outdated Show resolved Hide resolved
cli/src/android/update.ts Outdated Show resolved Hide resolved
@jcesarmobile jcesarmobile changed the title feat(android): Add support for Kotlin in capacitor-cordova-android-plugins fix(android): compatibility with cordova kotlin plugins Feb 21, 2022
@IT-MikeS IT-MikeS merged commit 55bf004 into main Feb 21, 2022
@IT-MikeS IT-MikeS deleted the feat/kotlin-capacitor-cordova-android branch February 21, 2022 19:53
@LifeIsStrange
Copy link

Thanks @IT-MikeS !!

@jcesarmobile jcesarmobile mentioned this pull request Feb 21, 2022
Closed
@jcesarmobile jcesarmobile mentioned this pull request Mar 3, 2022
Closed
This was referenced Mar 30, 2022
Closed
Closed
Closed
This was referenced Apr 25, 2022
Closed
Closed
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request May 12, 2022
Closed
This was referenced Jun 1, 2022
Closed
Closed
@sync-by-unito sync-by-unito bot mentioned this pull request Jun 20, 2022
Closed
This was referenced Jul 1, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giralte-ionic giralte-ionic giralte-ionic approved these changes

@jcesarmobile jcesarmobile jcesarmobile approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IT-MikeS @LifeIsStrange @jcesarmobile @giralte-ionic