-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): Option to inline JS source maps during sync #5843
Merged
Merged
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5a00b41
adding sourcemap inlining task
theproducer 423366f
locate correct js directory
theproducer 52aafaf
adds an `—inline` sync flag
theproducer c5e89a6
Merge branch 'main' into feat/cli-inline-sourcemaps
theproducer 35dcbb1
typo
theproducer d4ae700
fmt
theproducer 1d94a45
Walk the entire build assets folder for JS files
theproducer a5df265
fmt
theproducer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
import { | ||
readdirSync, | ||
existsSync, | ||
readFileSync, | ||
writeFileSync, | ||
unlinkSync, | ||
} from '@ionic/utils-fs'; | ||
import { join, extname } from 'path'; | ||
|
||
import type { Config } from '../definitions'; | ||
import { logger } from '../log'; | ||
|
||
function findJSAssetsDir(buildDir: string): string { | ||
const reactJSDir = '/static/js'; | ||
const vueJSDir = '/js'; | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Path.join is required for folder separators which will change based on platform (eg on windows its \ rather than /) |
||
|
||
if (existsSync(buildDir + reactJSDir)) { | ||
return reactJSDir; | ||
} | ||
|
||
if (existsSync(buildDir + vueJSDir)) { | ||
return vueJSDir; | ||
} | ||
|
||
return '/'; | ||
} | ||
|
||
export async function inlineSourceMaps( | ||
config: Config, | ||
platformName: string, | ||
): Promise<void> { | ||
let buildDir = ''; | ||
|
||
if (platformName == config.ios.name) { | ||
buildDir = await config.ios.webDirAbs; | ||
} | ||
|
||
if (platformName == config.android.name) { | ||
buildDir = await config.android.webDirAbs; | ||
} | ||
|
||
if (buildDir) { | ||
logger.info('Inlining sourcemaps'); | ||
const jsAssetsDir = findJSAssetsDir(buildDir); | ||
buildDir += jsAssetsDir; | ||
|
||
const files = readdirSync(buildDir); | ||
files.forEach(file => { | ||
const mapFile = join(buildDir, `${file}.map`); | ||
if (extname(file) === '.js' && existsSync(mapFile)) { | ||
const targetFile = join(buildDir, file); | ||
const bufMap = readFileSync(mapFile).toString('base64'); | ||
const bufFile = readFileSync(targetFile, 'utf8'); | ||
const result = bufFile.replace( | ||
`sourceMappingURL=${file}.map`, | ||
'sourceMappingURL=data:application/json;charset=utf-8;base64,' + | ||
bufMap, | ||
); | ||
writeFileSync(targetFile, result); | ||
unlinkSync(mapFile); | ||
} | ||
}); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JS files could be any folder. Im not sure you would want to hard code this for React and Vue.