Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(android): handle empty permission list #6375

Merged
merged 2 commits into from
Mar 8, 2023
Merged

fix(android): handle empty permission list #6375

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c291a00
fix(android): handle empty permission list
jcesarmobile Mar 8, 2023
3efb679
Merge branch 'main' into super-permissions
jcesarmobile Mar 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions android/capacitor/src/main/java/com/getcapacitor/Plugin.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -800,10 +800,12 @@ public void requestPermissions(PluginCall call) {
JSArray providedPerms = call.getArray("permissions");
List<String> providedPermsList = null;

try {
providedPermsList = providedPerms.toList();
} catch (JSONException ignore) {
// do nothing
if (providedPerms != null) {
try {
providedPermsList = providedPerms.toList();
} catch (JSONException ignore) {
// do nothing
}
}

// If call was made without any custom permissions, request all from plugin annotation
Expand Down