fix(http): pass original url as query param on the proxy url #7527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
michaelwolz
force-pushed
the
fix/url-encoding
branch
from
17f213b
to
6c4e22d
Compare
michaelwolz
force-pushed
the
fix/url-encoding
branch
from
b766f03
to
70cf26e
Compare
jcesarmobile
requested changes
Jul 30, 2024
android/capacitor/src/main/java/com/getcapacitor/WebViewLocalServer.java
Outdated
Show resolved
Hide resolved
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
jcesarmobile
changed the title
jcesarmobile
requested review from
andredestro,
markemer,
EiyuuZack,
theproducer,
carlpoole,
ItsChaceD,
IT-MikeS and
Steven0351
Steven0351
approved these changes
Jul 31, 2024
jcesarmobile
added a commit
that referenced
this pull request
Aug 5, 2024
Co-authored-by: jcesarmobile <jcesarmobile@gmail.com>
jcesarmobile
added a commit
that referenced
this pull request
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following up #7523.
This suggestion addresses the issue of non-encoded URLs in patched fetch and XHR requests. By encoding the full original URL and appending it as a parameter to the bridge/proxy URL, this solution should be more robust when passed to the native code. Also, there is no longer a need to distinguish between HTTP and HTTPS URLs separately, as this information is already embedded in the encoded URL parameter.
Working test implementation can be found here (including an example with non 80 port): https://github.com/michaelwolz/capacitor-tests/tree/fix/url-encoding
closes #7585
closes #7523