Renaming iOS classes to not conflict with future cordova-ios release #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Finally I decided to rename the classes on my cordova-ios fork directly so it'll work with all existing engine plugins out of the box. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Apple will stop accepting submissions of app having any reference of UIWebView in the future and started to warn developers on that aspect, the
cordova-iosproject will have to make a move to WKWebView as default engine.An issue is already opened apache/cordova-ios#661, as well as a PR from myself (apache/cordova-ios#663) that is embedding the classes of the
cordova-plugin-wkwebview-enginethat share similar names as the one used by some classes incordova-plugin-ionic-webview, provoking duplicate symbols at build time.This PR includes refactoring of all CDV*.h/.m files of this plugin to ION*.h/.m naming convention instead.
It has been tested on a Ionic project using both forked
cordova-iosfrom https://github.com/bpresles/cordova-ios, that include CDVWKWebViewEngine and the present modifiedcordova-plugin-ionic-webviewfrom https://github.com/bpresles/cordova-plugin-ionic-webview and the app is indeed using Ionic WKWebView correctly:2019-09-04 00:12:42.405396+0200 MyApp[87841:1187296] Using Ionic WKWebView