fix(cordova): Adjust app paths for cordova-ios 7 #5065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as abuse.
This comment was marked as abuse.
|
When will this change will be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cordova-ios 7 changed the .ipa/.app paths
apache/cordova-ios#1310
This PR adjust the path if executed in cordova-ios >= 7.
Created a new
getPackagePathCordovafunction to not edit the existinggetPackagePath, since it's exported maybe somebody is using it and could be breaking to change it.Only call the new method if the
getPackageJsondoesn't return an undefinedpkg.closes #5048