-
Notifications
You must be signed in to change notification settings - Fork 13.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(tabs): fix preloadTabs null element reference
Closes #7109
- Loading branch information
1 parent
55a5e83
commit 2d19308
Showing
1 changed file
with
4 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2d19308
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adamdbradley we don't have any e2e test with
preloadTabs="true"
, I think we should have at least one to prevent this regression again :) do you want me to add it?2d19308
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi guys, after adding the above commit to beta10 the following decor div:
<div class="nav-decor"></div>
started showing up during transition. I'm using beta 10 + this commit.
Any chance of getting a brief summary of how that div is used ? I set its index to 0 for now.