Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

placeholder mixin should use a global sass variable #10153

Closed
badpenguin opened this issue Jan 24, 2017 · 2 comments · Fixed by #10188
Closed

placeholder mixin should use a global sass variable #10153

badpenguin opened this issue Jan 24, 2017 · 2 comments · Fixed by #10188
Assignees
Milestone

Comments

@badpenguin
Copy link

Ionic version:
[ ] 1.x
[X] 2.x

I'm submitting a ...
[ ] bug report
[X] feature request
[ ] support request

Current behavior:
in input.scss:

.text-input {
  @include placeholder();

Expected behavior:

.text-input {
  @include placeholder($placeholder-text-color);

OR change the mixin declaration from:

@mixin placeholder($color: #999, $text-indent: 0) {

to:

@mixin placeholder($color: $placeholder-text-color, $text-indent: 0) {
@badpenguin
Copy link
Author

can i say: "AWESOME GUYS" ? :)

@ionitron-bot
Copy link

ionitron-bot bot commented Sep 4, 2018

Thanks for the issue! This issue is being locked to prevent comments that are not relevant to the original issue. If this is still an issue with the latest version of Ionic, please create a new issue and ensure the template is fully filled out.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants