Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-item-sliding doesn't slide if Chrome Dev Tools is open #6958

Closed
vk2sky opened this issue Jun 18, 2016 · 9 comments
Closed

ion-item-sliding doesn't slide if Chrome Dev Tools is open #6958

vk2sky opened this issue Jun 18, 2016 · 9 comments
Assignees

Comments

@vk2sky
Copy link

vk2sky commented Jun 18, 2016

Short description of the problem:

component doesn't slide in Chrome if Dev Tools are open

What behavior are you expecting?

List element should slide regardless of state of Dev Tools

Steps to reproduce:

  1. Create page with the template below
  2. With Chrome Dev Tools closed, verify that sliding the SLIDE ME list item to the left reveals clipboard and trash option buttons
  3. Open Dev Tools. TEST item can no longer slide
<ion-content>
  <ion-list>
    <ion-item-sliding>
      <ion-item><ion-label>SLIDE ME</ion-label></ion-item>

      <ion-item-options>
        <button><ion-icon name="clipboard"></ion-icon></button>
        <button><ion-icon name="trash"></ion-icon></button>
      </ion-item-options>
    </ion-item-sliding>
  </ion-list>
</ion-content>

Other information:
Chrome version 51.0.2704.103 (64-bit)
Works in Firefox 47.0, so perhaps this is a Chrome issue.

Which Ionic Version? 1.x or 2.x
2.0.0.beta.9

Plunker that shows an example of your issue

(not supplied)

Run ionic info from terminal/cmd prompt: (paste output below)
Your system information:

Cordova CLI: 6.2.0
Ionic Framework Version: 2.0.0-beta.9
Ionic CLI Version: 2.0.0-beta.30
Ionic App Lib Version: 2.0.0-beta.16
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v5.5.0
Xcode version: Xcode 7.3.1 Build version 7D1014

@vk2sky
Copy link
Author

vk2sky commented Jun 19, 2016

For what it's worth, I thought that maybe Chrome Dev Tools was hijacking drag events, but this appears not to be the case. For example, the demo page for ng2-dragula (http://valor-software.com/ng2-dragula/) works even when Dev Tools is open.

@jgw96
Copy link
Contributor

jgw96 commented Jun 20, 2016

Hello, thanks for opening an issue with us! Does it happen only when you are using device emulation? Thanks for using Ionic!

@jgw96 jgw96 added the needs: reply the issue needs a response from the user label Jun 20, 2016
@vk2sky
Copy link
Author

vk2sky commented Jun 23, 2016

Hi @jgw96, sorry for the delay in replying.

I observed tThis problem while running the app in the Chrome browser via the "ionic serve" command.

@Ionitron Ionitron removed the needs: reply the issue needs a response from the user label Jun 23, 2016
@jgw96
Copy link
Contributor

jgw96 commented Jun 23, 2016

No problem! I just tested this with our ionic-conference-app in the latest chrome and it seems to be working for me. Would you mind giving that app a try and see if the sliding items on the first page work for you?

@jgw96 jgw96 added the needs: reply the issue needs a response from the user label Jun 23, 2016
@vk2sky
Copy link
Author

vk2sky commented Jun 25, 2016

Thanks @jgw96 . I've done some more investigation, and reproduced the problem with the ionic-conference-app. Here's the sequence:

  1. With Chrome Dev Tools off, start the app, and skip past the intro screen
  2. Verify that list items can be swiped to reveal the "Favorite" option. Swipe back to hide the option.
  3. Open Chrome Dev Tools.
  4. Try swiping a list item again. For me, swipe does not reveal the "Favorite" option.
  5. Leaving Dev Tools open, refresh the browser screen, and again skip the intro.
  6. Now swipe works as expected.

My updated ionic info:

Cordova CLI: 6.2.0
Ionic Framework Version: 2.0.0-beta.9
Ionic CLI Version: 2.0.0-beta.32
Ionic App Lib Version: 2.0.0-beta.18
ios-deploy version: 1.8.6
ios-sim version: 5.0.8
OS: Mac OS X El Capitan
Node Version: v5.5.0
Xcode version: Xcode 7.3.1 Build version 7D1014

@Ionitron Ionitron removed the needs: reply the issue needs a response from the user label Jun 25, 2016
@chandanch
Copy link

Hello, Guys even I'm facing the same problem, When I enable the device emulation it doesn't work in chrome

@jgw96
Copy link
Contributor

jgw96 commented Jun 27, 2016

@vk2sky yep, that is what i expected. We have also been experiencing this and it seems to be a chrome bug related to emulating touch events. I can happily report though, that on the latest chrome canary it seems to be happening less, so it looks like they may be working on this bug. I would recommend opening an issue with the chrome. Thanks for using Ionic! As this is a chrome bug and not an ionic bug i am going to be closing this issue for now.

@jgw96 jgw96 closed this as completed Jun 27, 2016
@manucorporat
Copy link
Contributor

@jgw96 it is a hammer bug, this was a real bug! but I have a fix.

@manucorporat manucorporat reopened this Jul 3, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Jul 3, 2016
- sliding should behave exactly like a native one
- much better performance

references ionic-team#7049
references ionic-team#7116
closes ionic-team#6913
closes ionic-team#6958
manucorporat added a commit to manucorporat/ionic that referenced this issue Jul 3, 2016
- sliding should behave exactly like a native one
- much better performance

references ionic-team#7049
references ionic-team#7116
closes ionic-team#6913
closes ionic-team#6958
@jgw96
Copy link
Contributor

jgw96 commented Jul 5, 2016

@manucorporat thanks for taking another look at this!

manucorporat added a commit to manucorporat/ionic that referenced this issue Jul 12, 2016
- sliding should behave exactly like a native one
- much better performance

references ionic-team#7049
references ionic-team#7116
closes ionic-team#6913
closes ionic-team#6958
@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants