Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ion-content continues to scroll while swiping side menu iOS RC1 #9130

Closed
jmordica opened this issue Nov 12, 2016 · 7 comments
Closed

ion-content continues to scroll while swiping side menu iOS RC1 #9130

jmordica opened this issue Nov 12, 2016 · 7 comments

Comments

@jmordica
Copy link

Short description of the problem:

In Ionic 2 RC1, when using this.menu.swipeEnable(true); on pages with ion-content, you should set the page to not allow scrolling because as the swipe is taking place, the content area continues to move. This has only been tested on iOS

Steps to reproduce:

  1. Swipe to reveal the side menu
  2. Move your thumb vertically (up and down while swiping to reveal the menu)
  3. If you page has ion-content, you'll see the content scrolling
@jmordica jmordica changed the title ion-content continues to scroll while swiping side menu RC1 ion-content continues to scroll while swiping side menu iOS RC1 Nov 12, 2016
@jgw96 jgw96 added the v2 label Nov 14, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 15, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 15, 2016
manucorporat added a commit to manucorporat/ionic that referenced this issue Nov 15, 2016
@jmordica
Copy link
Author

I don't believe this issue was resolved. I do see it being tagged in RC3 but i've just updated and attempted the same behavior with the same results.

I see a few places in your commits that should have resolved this but didn't seem to do the trick. Here is an exact example of what is happening below:

content_scroll

Lastly, not sure if this has anything to do with it, but I have this in my app.module.ts which actually fixed a few keyboard/form overlapping issues

IonicModule.forRoot(MyApp, {
            platforms: {
                ios: {
                    scrollAssist: false,
                    autoFocusAssist: false
                }
            }
        }),

Hopefully this is enough info.

Thanks.

@biesbjerg
Copy link

As far as I know, this has been fixed when using WKWebView only. That comes with its own set of issues though.

@manucorporat
Copy link
Contributor

manucorporat commented Nov 25, 2016

This is already in RC3 using ionic's WKWebview plugin. There is not way to stop ongoing scrolling in UIWebView.

The current solution is hybrid, there are not API we can use in safari to stop scrolling without causing flickering.

@jmordica
Copy link
Author

I'm using the wkwebview plugin btw. Forgot to mention that. I set it up exactly like the ionic post recommended.

@manucorporat
Copy link
Contributor

@jmordica have you updated to the latest version of the plugin?

@jmordica
Copy link
Author

Yes but for some reason cordova plugin list shows:

cordova-plugin-wkwebview-engine 1.1.1-dev "Cordova WKWebView Engine"

Still trying to figure out why it's not showing your master branch data here

@jmordica
Copy link
Author

Ok So i updated wkwebview and seemed to fix the issue! The content area no longer moves when dragging the side menu.

Case closed.

@ionitron-bot ionitron-bot bot locked and limited conversation to collaborators Sep 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants